1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 10:42:41 +01:00
phorge-phorge/resources/builtin
epriestley 65ff40844b Make modular transforms handle exceptions gracefully
Summary:
Ref T7707. Ref T2479. Ref T5258.

The thumbnailing code is some of the only code in the codebase which doesn't use exceptions to handle errors. I'm going to convert it to use exceptions; make sure they do something reasonable at top level.

Strategy here is:

  - By default, we just fall back to a placeholder image if anything goes wrong.
  - Later, I'll likely add a "debug" workflow from the new "Transforms" UI which will surface the specific exception instead (the code can't really raise any interesting exceptions right now).

Test Plan: Faked an exception and saw some reasonable default images.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5258, T2479, T7707

Differential Revision: https://secure.phabricator.com/D12809
2015-05-13 11:38:45 -07:00
..
macro/phabricator1 Emoticons, Pack 1 2013-08-02 12:00:26 -07:00
image-100x100.png Make modular transforms handle exceptions gracefully 2015-05-13 11:38:45 -07:00
image-220x220.png Make modular transforms handle exceptions gracefully 2015-05-13 11:38:45 -07:00
image-280x210.png Make modular transforms handle exceptions gracefully 2015-05-13 11:38:45 -07:00
missing.png Provide "builtin" files and use them to fix Pholio when files are deleted 2013-05-08 18:12:52 -07:00
profile.png Clean up image loading for ExternalAccounts 2013-06-17 12:14:00 -07:00
project.png Add an icon+background selector for project images 2013-10-17 09:32:34 -07:00