mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-24 07:42:40 +01:00
402d2e2605
Summary: Fixes T3143. When a user deletes a file, delete all transforms of the file too. In particular, this means that deleting an image deletes all the thumbnails of the image. In most cases, this aligns with user expectations. The only sort of weird case I can come up with is that memes are transformations of the source macro image, so deleting grumpycat will delete all the hilarious grumpycat memes. This seems not-too-unreasonable, though, and desirable if someone accidentally uploads an inappropriate image which is promptly turned into a meme. Test Plan: Added a unit test which covers both inbound and outbound transformations. Uploaded a file and deleted it, verified its thumbnail was also deleted. Reviewers: chad, btrahan, joseph.kampf Reviewed By: btrahan CC: aran, joseph.kampf Maniphest Tasks: T3143 Differential Revision: https://secure.phabricator.com/D5879 |
||
|---|---|---|
| .. | ||
| application | ||
| conduit | ||
| config | ||
| controller | ||
| engine | ||
| engineselector | ||
| exception | ||
| lipsum | ||
| management | ||
| query | ||
| remarkup | ||
| storage | ||
| view | ||
| PhabricatorImageTransformer.php | ||