mirror of
https://we.phorge.it/source/phorge.git
synced 2025-03-02 23:49:19 +01:00
Summary: This moves Diffusion History to use an easier to parse list view for commits and their (diff, audit, build) status. I left TableView around, which is used on a repositories home, and we can maybe add a "graph view" history back as another controller. Not sure what the real use is for that kind of feature though. I don't have Harbormaster set up locally so I could use another install to give this a run. I also expect to maybe not live with this UI as final, I like the UX, but the icons for indicating status don't really feel great to me, just OK. Test Plan: pull various repositories, check various history displays. {F4980356} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D18039
196 lines
5.4 KiB
PHP
196 lines
5.4 KiB
PHP
<?php
|
|
|
|
final class DiffusionHistoryTableView extends DiffusionHistoryView {
|
|
|
|
public function render() {
|
|
$drequest = $this->getDiffusionRequest();
|
|
|
|
$viewer = $this->getUser();
|
|
|
|
$buildables = $this->loadBuildables(
|
|
mpull($this->getHistory(), 'getCommit'));
|
|
$has_any_build = false;
|
|
|
|
$show_revisions = PhabricatorApplication::isClassInstalledForViewer(
|
|
'PhabricatorDifferentialApplication',
|
|
$viewer);
|
|
|
|
$handles = $viewer->loadHandles($this->getRequiredHandlePHIDs());
|
|
|
|
$graph = null;
|
|
if ($this->getParents()) {
|
|
$parents = $this->getParents();
|
|
|
|
// If we're filtering parents, remove relationships which point to
|
|
// commits that are not part of the visible graph. Otherwise, we get
|
|
// a big tree of nonsense when viewing release branches like "stable"
|
|
// versus "master".
|
|
if ($this->getFilterParents()) {
|
|
foreach ($parents as $key => $nodes) {
|
|
foreach ($nodes as $nkey => $node) {
|
|
if (empty($parents[$node])) {
|
|
unset($parents[$key][$nkey]);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
$graph = id(new PHUIDiffGraphView())
|
|
->setIsHead($this->getIsHead())
|
|
->setIsTail($this->getIsTail())
|
|
->renderGraph($parents);
|
|
}
|
|
|
|
$show_builds = PhabricatorApplication::isClassInstalledForViewer(
|
|
'PhabricatorHarbormasterApplication',
|
|
$this->getUser());
|
|
|
|
$rows = array();
|
|
$ii = 0;
|
|
foreach ($this->getHistory() as $history) {
|
|
$epoch = $history->getEpoch();
|
|
|
|
if ($epoch) {
|
|
$committed = $viewer->formatShortDateTime($epoch);
|
|
} else {
|
|
$committed = null;
|
|
}
|
|
|
|
$data = $history->getCommitData();
|
|
$author_phid = $committer = $committer_phid = null;
|
|
if ($data) {
|
|
$author_phid = $data->getCommitDetail('authorPHID');
|
|
$committer_phid = $data->getCommitDetail('committerPHID');
|
|
$committer = $data->getCommitDetail('committer');
|
|
}
|
|
|
|
if ($author_phid && isset($handles[$author_phid])) {
|
|
$author = $handles[$author_phid]->renderLink();
|
|
} else {
|
|
$author = self::renderName($history->getAuthorName());
|
|
}
|
|
|
|
$different_committer = false;
|
|
if ($committer_phid) {
|
|
$different_committer = ($committer_phid != $author_phid);
|
|
} else if ($committer != '') {
|
|
$different_committer = ($committer != $history->getAuthorName());
|
|
}
|
|
if ($different_committer) {
|
|
if ($committer_phid && isset($handles[$committer_phid])) {
|
|
$committer = $handles[$committer_phid]->renderLink();
|
|
} else {
|
|
$committer = self::renderName($committer);
|
|
}
|
|
$author = hsprintf('%s/%s', $author, $committer);
|
|
}
|
|
|
|
// We can show details once the message and change have been imported.
|
|
$partial_import = PhabricatorRepositoryCommit::IMPORTED_MESSAGE |
|
|
PhabricatorRepositoryCommit::IMPORTED_CHANGE;
|
|
|
|
$commit = $history->getCommit();
|
|
if ($commit && $commit->isPartiallyImported($partial_import) && $data) {
|
|
$summary = AphrontTableView::renderSingleDisplayLine(
|
|
$history->getSummary());
|
|
} else {
|
|
$summary = phutil_tag('em', array(), pht("Importing\xE2\x80\xA6"));
|
|
}
|
|
|
|
$build = null;
|
|
if ($show_builds) {
|
|
$buildable = idx($buildables, $commit->getPHID());
|
|
if ($buildable !== null) {
|
|
$build = $this->renderBuildable($buildable);
|
|
$has_any_build = true;
|
|
}
|
|
}
|
|
|
|
$browse = $this->linkBrowse(
|
|
$history->getPath(),
|
|
array(
|
|
'commit' => $history->getCommitIdentifier(),
|
|
'branch' => $drequest->getBranch(),
|
|
'type' => $history->getFileType(),
|
|
));
|
|
|
|
$status = $commit->getAuditStatus();
|
|
$icon = PhabricatorAuditCommitStatusConstants::getStatusIcon($status);
|
|
$color = PhabricatorAuditCommitStatusConstants::getStatusColor($status);
|
|
$name = PhabricatorAuditCommitStatusConstants::getStatusName($status);
|
|
|
|
$audit_view = id(new PHUIIconView())
|
|
->setIcon($icon, $color)
|
|
->addSigil('has-tooltip')
|
|
->setMetadata(
|
|
array(
|
|
'tip' => $name,
|
|
));
|
|
|
|
$rows[] = array(
|
|
$graph ? $graph[$ii++] : null,
|
|
$browse,
|
|
self::linkCommit(
|
|
$drequest->getRepository(),
|
|
$history->getCommitIdentifier()),
|
|
$build,
|
|
$audit_view,
|
|
($commit ?
|
|
self::linkRevision(idx($this->getRevisions(), $commit->getPHID())) :
|
|
null),
|
|
$author,
|
|
$summary,
|
|
$committed,
|
|
);
|
|
}
|
|
|
|
$view = new AphrontTableView($rows);
|
|
$view->setHeaders(
|
|
array(
|
|
null,
|
|
null,
|
|
pht('Commit'),
|
|
null,
|
|
null,
|
|
null,
|
|
pht('Author'),
|
|
pht('Details'),
|
|
pht('Committed'),
|
|
));
|
|
$view->setColumnClasses(
|
|
array(
|
|
'threads',
|
|
'nudgeright',
|
|
'',
|
|
'icon',
|
|
'icon',
|
|
'',
|
|
'',
|
|
'wide',
|
|
'right',
|
|
));
|
|
$view->setColumnVisibility(
|
|
array(
|
|
$graph ? true : false,
|
|
true,
|
|
true,
|
|
$has_any_build,
|
|
true,
|
|
$show_revisions,
|
|
));
|
|
$view->setDeviceVisibility(
|
|
array(
|
|
$graph ? true : false,
|
|
true,
|
|
true,
|
|
true,
|
|
true,
|
|
true,
|
|
false,
|
|
true,
|
|
false,
|
|
));
|
|
return $view->render();
|
|
}
|
|
|
|
}
|