mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-03 04:02:43 +01:00
e55a197dd6
Summary: Ref T2015. This fixes issues where the Drydock queries wouldn't filter (or throw an exception) when passed empty arrays for their `with` methods. In addition, this also adds `array_unique` to the resource and lease subqueries so that we don't pull in a bunch of stuff if logs or leases have the same related objects. Test Plan: Tested it by using DarkConsole on the log controller. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: joshuaspence, Korvin, epriestley Maniphest Tasks: T2015 Differential Revision: https://secure.phabricator.com/D10879
112 lines
2.3 KiB
PHP
112 lines
2.3 KiB
PHP
<?php
|
|
|
|
final class DrydockLeaseQuery extends DrydockQuery {
|
|
|
|
private $ids;
|
|
private $phids;
|
|
private $resourceIDs;
|
|
private $statuses;
|
|
private $datasourceQuery;
|
|
|
|
public function withIDs(array $ids) {
|
|
$this->ids = $ids;
|
|
return $this;
|
|
}
|
|
|
|
public function withPHIDs(array $phids) {
|
|
$this->phids = $phids;
|
|
return $this;
|
|
}
|
|
|
|
public function withResourceIDs(array $ids) {
|
|
$this->resourceIDs = $ids;
|
|
return $this;
|
|
}
|
|
|
|
public function withStatuses(array $statuses) {
|
|
$this->statuses = $statuses;
|
|
return $this;
|
|
}
|
|
|
|
public function newResultObject() {
|
|
return new DrydockLease();
|
|
}
|
|
|
|
public function withDatasourceQuery($query) {
|
|
$this->datasourceQuery = $query;
|
|
return $this;
|
|
}
|
|
|
|
protected function loadPage() {
|
|
return $this->loadStandardPage($this->newResultObject());
|
|
}
|
|
|
|
protected function willFilterPage(array $leases) {
|
|
$resource_ids = array_filter(mpull($leases, 'getResourceID'));
|
|
if ($resource_ids) {
|
|
$resources = id(new DrydockResourceQuery())
|
|
->setParentQuery($this)
|
|
->setViewer($this->getViewer())
|
|
->withIDs(array_unique($resource_ids))
|
|
->execute();
|
|
} else {
|
|
$resources = array();
|
|
}
|
|
|
|
foreach ($leases as $key => $lease) {
|
|
$resource = null;
|
|
if ($lease->getResourceID()) {
|
|
$resource = idx($resources, $lease->getResourceID());
|
|
if (!$resource) {
|
|
unset($leases[$key]);
|
|
continue;
|
|
}
|
|
}
|
|
$lease->attachResource($resource);
|
|
}
|
|
|
|
return $leases;
|
|
}
|
|
|
|
protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
|
|
$where = parent::buildWhereClauseParts($conn);
|
|
|
|
if ($this->resourceIDs !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'resourceID IN (%Ld)',
|
|
$this->resourceIDs);
|
|
}
|
|
|
|
if ($this->ids !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'id IN (%Ld)',
|
|
$this->ids);
|
|
}
|
|
|
|
if ($this->phids !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'phid IN (%Ls)',
|
|
$this->phids);
|
|
}
|
|
|
|
if ($this->statuses !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'status IN (%Ld)',
|
|
$this->statuses);
|
|
}
|
|
|
|
if ($this->datasourceQuery !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'id = %d',
|
|
(int)$this->datasourceQuery);
|
|
}
|
|
|
|
return $where;
|
|
}
|
|
|
|
}
|