1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/herald
epriestley 63f4e66b11 Attach HeraldRules to HeraldEffects
Summary:
Ref T7731. For no particular reason, we currently put `ruleID` and `rulePHID` on `HeraldEffect` objects.

Pretty much all callers need the `HeraldRule` objects instead, and some go to great lengths to get them.

Just attach the `Rule` objects.

Test Plan: Will test thoroughly after next-ish changeset.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7731

Differential Revision: https://secure.phabricator.com/D12269
2015-04-06 10:00:45 -07:00
..
adapter Attach HeraldRules to HeraldEffects 2015-04-06 10:00:45 -07:00
application Allow applications to have multiple "help" menu items 2015-04-01 11:51:48 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
config Lay most groundwork for Herald object rules 2013-12-27 13:17:10 -08:00
controller Remove Controller->getHandle() and Controller->loadHandles() 2015-03-31 05:48:20 -07:00
editor Modularize mail tags 2014-08-12 12:28:41 -07:00
engine Attach HeraldRules to HeraldEffects 2015-04-06 10:00:45 -07:00
extension Support custom actions in Herald 2014-07-02 14:29:46 +10:00
garbagecollector Modularize the Garbage Collector 2014-01-15 10:02:24 -08:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Herald queries correctly label Object Rules 2015-04-02 05:00:51 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
storage Attach HeraldRules to HeraldEffects 2015-04-06 10:00:45 -07:00
view Make ObjectItem default as "Card" 2014-06-07 12:12:11 -07:00