epriestley 8ad61d0150 Simplify "builtin file" management and recover from races ... Summary: Fixes T11307. Fixes T8124. Currently, builtin files are tracked by using a special transform with an invalid source ID. Just use a dedicated column instead. The transform thing is too clever/weird/hacky and exposes us to issues with the "file" and "transform" tables getting out of sync (possibly the issue in T11307?) and with race conditions. Test Plan: - Loaded profile "edit picture" page, saw builtins. - Deleted all builtin files, put 3 second sleep in the storage engine write, loaded profile page in two windows. - Before patch: one of them failed with a race. - After patch: both of them loaded. Reviewers: chad Reviewed By: chad Maniphest Tasks: T8124, T11307 Differential Revision: https://secure.phabricator.com/D16271		2016-07-11 09:25:34 -07:00
..
__tests__	Scramble file secrets when related objects change policies	2016-04-06 14:14:16 -07:00
PhabricatorFile.php	Simplify "builtin file" management and recover from races	2016-07-11 09:25:34 -07:00
PhabricatorFileChunk.php	Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine	2015-05-15 14:07:17 -07:00
PhabricatorFileDAO.php	Remove @group annotations	2014-07-10 08:12:48 +10:00
PhabricatorFileSchemaSpec.php	Automatically build all Lisk schemata	2014-10-02 09:51:20 -07:00
PhabricatorFileStorageBlob.php	Fix visiblity of LiskDAO::getConfiguration()	2015-01-14 06:54:13 +11:00
PhabricatorFileTransaction.php	File names should be editable.	2015-04-26 15:24:29 -07:00
PhabricatorFileTransactionComment.php	Fix visiblity of LiskDAO::getConfiguration()	2015-01-14 06:54:13 +11:00
PhabricatorTransformedFile.php	Fix visiblity of LiskDAO::getConfiguration()	2015-01-14 06:54:13 +11:00