epriestley 223d7b84dd Recover more gracefully when favicon configuration points at a corrupt/damaged file ... Summary: Ref T13103. Locally, I managed to break the data for a bunch of files by doing `git clean -df` in a working copy that I'd updated to a commit from many many years ago. Since `conf/local.json` wasn't on the gitignore list many years ago, this removed it, and I lost my encryption keyring. I've symlinked my local config to a version-controlled file now to avoid this specific type of creative self-sabotage in the future, but this has exposed a few cases where we could handle things more gracefully. One issue is that if your favicon is customized but the file it points at can't actually be loaded, we fail explosively and you really can't do anything to move forward except somehow guess that you need to fix your favicon. Instead, recover more gracefully. Test Plan: - Configure file encryption. - Configure a favicon. - Remove the encryption key from your keyring. - Purge Phabricator's caches. - Before: you pretty much dead-end on a fatal that's hard to understand/fix. - After: everything works except your favicon. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13103 Differential Revision: https://secure.phabricator.com/D19406		2018-04-27 12:02:32 -07:00
..
PhabricatorFaviconRef.php	Recover more gracefully when favicon configuration points at a corrupt/damaged file	2018-04-27 12:02:32 -07:00
PhabricatorFaviconRefQuery.php	Dynamically composite favicons from customizable sources	2018-03-12 15:28:41 -07:00