1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 19:32:40 +01:00
phorge-phorge/src/applications/almanac/storage
Bob Trahan 3ef0721ada Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine
Summary:
Fixes T6956. Before this change, we called PhabricatorUser::getOmnipotentUser in the various delete methods to query the data. Now, we use $engine->getViewer(), since its always a good thing to have less calls to PhabricatorUser::getOmnipotentUser thrown around the codebase.

I used the "codemod" tool to audit the existing calls to PhabricatorDestructorEngine (all of them) so ostensibly this gets all the spots. If I missed something though, its still going to work, so this change is very low risk.

Test Plan: ./bin/remove destroy P1; visit P1 and get a 404

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6956

Differential Revision: https://secure.phabricator.com/D12866
2015-05-15 14:07:17 -07:00
..
AlmanacBinding.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
AlmanacBindingTransaction.php Add AlmanacBinding, to bind a service to an interface 2014-10-27 13:39:36 -07:00
AlmanacDAO.php Implement storage of a host ID and a public key for authorizing Conduit between servers 2014-10-03 22:52:41 +10:00
AlmanacDevice.php Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine 2015-05-15 14:07:17 -07:00
AlmanacDeviceTransaction.php Build AlmanacInterface 2014-10-17 05:04:24 -07:00
AlmanacInterface.php Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine 2015-05-15 14:07:17 -07:00
AlmanacNetwork.php Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine 2015-05-15 14:07:17 -07:00
AlmanacNetworkTransaction.php Build AlmanacNetwork 2014-10-17 05:04:02 -07:00
AlmanacProperty.php Move property transaction construction to Almanac 2015-03-23 09:10:42 -07:00
AlmanacSchemaSpec.php Implement PhabricatorProjectInterface on Almanac Services and Devices 2014-11-05 15:30:00 -08:00
AlmanacService.php Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine 2015-05-15 14:07:17 -07:00
AlmanacServiceTransaction.php Allow Almanac services to be locked 2014-12-18 14:31:36 -08:00