1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/config
Ricky Elrod e990488889 Set some defaults back to correctness.
Summary:
There were a few defaults that got changed when porting to PHP. Most of them
seem to be accidental, so this diff sets them back to correctness.

Test Plan:
  php> require '../libphutil/src/__phutil_library_init__.php';
  php> require 'src/__phutil_library_init__.php'
  php> $a = PhabricatorApplicationConfigOptions::loadAllOptions()
  php> $b = require 'conf/default.conf.php';
  php> $x = array();
  php> foreach($a as $key => $obj) { $x[$key] = $obj->getDefault(); }
  php> foreach($x as $key => $default) { if ($b[$key] != $default) { echo "$key has different default.\n"; } }

  log.access.format has different default.
  (seems to be intentional)

  PHP Notice:  Undefined index: phabricator.env in /usr/lib/python2.7/site-packages/phpsh/phpsh.php(577) : eval()'d code on line 1
  (no longer in config file)

  PHP Notice:  Undefined index: test.value in /usr/lib/python2.7/site-packages/phpsh/phpsh.php(577) : eval()'d code on line 1
  (not in config file)

  metamta.default-address has different default.
  (intentional)

  metamta.domain has different default.
  (intentional)

  PHP Notice:  Undefined index: phid.external-loaders in /usr/lib/python2.7/site-packages/phpsh/phpsh.php(577) : eval()'d code on line 1
  (no longer in config file)

  phame.skins has different default.
  (fixed in D4618)

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2255

Differential Revision: https://secure.phabricator.com/D4621
2013-01-24 12:10:41 -08:00
..
application Move mail-related setup issues to setup checks 2013-01-18 13:28:30 -08:00
check Move database configuration into new-style setup checks 2013-01-22 16:16:24 -08:00
controller Two minor Config sidebar tweaks. 2013-01-21 18:55:54 -08:00
editor Repair invalid configuration by setting values back to defaults 2013-01-17 16:25:38 -08:00
exception Allow configuration to be explicitly validated, including validation of complex attributes 2013-01-01 18:15:03 -08:00
issue Detect and raise setup warnings from within Phabricator 2012-12-30 06:37:49 -08:00
json Mask remaining config values, and implement set type 2013-01-16 15:06:07 -08:00
management Add enum option type. 2013-01-21 18:48:29 -08:00
option Set some defaults back to correctness. 2013-01-24 12:10:41 -08:00
query Use transactions to show edit history for Configuration 2013-01-01 18:14:41 -08:00
response Port extension checks to new-style setup 2013-01-22 15:16:26 -08:00
storage Use transactions to show edit history for Configuration 2013-01-01 18:14:41 -08:00
view Don't require phabricator.base-uri to be configured 2013-01-22 13:57:02 -08:00