1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
phorge-phorge/src
epriestley 65a2b5e219 Route hard-coded "/favicon.ico" requests to a favicon resource
Summary:
See PHI1719. User agents making hard-coded requests to "/favicon.ico" currently 404. This is a mild source of log noise, and we can reasonably route this request.

Limitations:

  - This only routes the "PlatformSite". Other sites (custom Phame blogs, third-party sites, Phurl redirectors) won't route here for now.
  - This returns a "Location:" redirect to the correct resource rather than icon data directly. This produces the right icon with the right caching behavior, and returning icon data directly is difficult in the general case. However, it won't perform/cache as well as a direct response would.

Test Plan:
  - Visted `/favicon.ico`.
  - Before: 404.
  - After: redirect to favicon.

Differential Revision: https://secure.phabricator.com/D21195
2020-05-01 05:23:00 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront When proxying HTTP repository responses from repository nodes, discard content description headers 2020-04-25 07:51:46 -07:00
applications Route hard-coded "/favicon.ico" requests to a favicon resource 2020-05-01 05:23:00 -07:00
docs Add "short name", "id", and "phid" variables for external editor URIs 2020-04-19 09:37:53 -07:00
extensions
infrastructure Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()" 2020-04-29 14:47:47 -07:00
view Stick the page footer in the right place on Formation View pages 2020-04-24 11:25:31 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Route hard-coded "/favicon.ico" requests to a favicon resource 2020-05-01 05:23:00 -07:00