1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/herald
epriestley 094922bcb9 Support "only the first time" in Maniphest
Summary:
Ref T4403. Implements "only the first time" for Maniphest rules, and fixes the trigger itself.

The trigger would never fire and block rules because it was comparing a string (like "first") to an int (like 0).

The "only" vs "every" stuff is contributed and I should have pushed back harder on this toInt / toString stuff. Maybe I'll just get rid of it; it purely causes confusion and problems.

Test Plan: Wrote an "only the first time" rule, ran it twice, it applied once.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4403

Differential Revision: https://secure.phabricator.com/D8193
2014-02-11 07:45:26 -08:00
..
adapter Support "only the first time" in Maniphest 2014-02-11 07:45:26 -08:00
application Split Herald rule creation across several steps 2013-12-27 13:16:25 -08:00
capability Remove the "create rules" Herald capability 2013-10-09 13:55:44 -07:00
config Lay most groundwork for Herald object rules 2013-12-27 13:17:10 -08:00
controller Herald - make herald condition of herald rule display better 2014-02-10 14:40:09 -08:00
editor Allow Herald rules to be disabled, instead of deleted 2013-10-06 17:10:29 -07:00
engine Support "only the first time" in Maniphest 2014-02-11 07:45:26 -08:00
garbagecollector Modularize the Garbage Collector 2014-01-15 10:02:24 -08:00
phid Give Herald rules a standard "Hnnn" object name 2013-12-18 12:00:18 -08:00
query Lay most groundwork for Herald object rules 2013-12-27 13:17:10 -08:00
remarkup Give Herald rules a standard "Hnnn" object name 2013-12-18 12:00:18 -08:00
storage Support "only the first time" in Maniphest 2014-02-11 07:45:26 -08:00
view Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00