revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-23 13:08:18 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/infrastructure/editor
History
Steve Campbell 65e57fe23d Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error 
Summary:
Under PHP 8.1, PhabricatorEditorURIEngine::newForViewer() is throwing a trim(NULL) error when trying to view a diff.
This is because it tries to apply string operations to a user setting which will be null by default.

Fixes T15518

Test Plan:
Unit test added -
  arc unit

Or just view a diff. Eg:
	https://my.phorge.site/D1234

Reviewers: O1 Blessed Committers, valerio.bozzolan, avivey

Reviewed By: O1 Blessed Committers, valerio.bozzolan, avivey

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15518

Differential Revision: https://we.phorge.it/D25324
2023-07-17 11:03:52 +01:00
..
__tests__ Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error 2023-07-17 11:03:52 +01:00
PhabricatorEditorURIEngine.php Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error 2023-07-17 11:03:52 +01:00
PhabricatorEditorURIParserException.php Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00