1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/conduit/controller
epriestley 661f077bf7 Replace callsites to sha1() that use it to asciify entropy with
Filesystem::readRandomCharacters()

Summary: See T547. To improve auditability of use of crypto-sensitive hash
functions, use Filesystem::readRandomCharacters() in place of
sha1(Filesystem::readRandomBytes()) when we're just generating random ASCII
strings.

Test Plan:
  - Generated a new PHID.
  - Logged out and logged back in (to test sessions).
  - Regenerated Conduit certificate.
  - Created a new task, verified mail key generated sensibly.
  - Created a new revision, verified mail key generated sensibly.
  - Ran "arc list", got blocked, installed new certificate, ran "arc list"
again.

Reviewers: jungejason, nh, tuomaspelkonen, aran, benmathews

Reviewed By: jungejason

CC: aran, epriestley, jungejason

Differential Revision: 1000
2011-10-21 11:55:28 -07:00
..
api Provide a better error message when a user enters a Conduit parameter string 2011-10-21 11:54:53 -07:00
base Provide basic Conduit documentation. 2011-07-04 12:03:36 -07:00
console Provide a paste.create Conduit method 2011-07-29 19:00:04 -07:00
log Provide basic Conduit documentation. 2011-07-04 12:03:36 -07:00
token Replace callsites to sha1() that use it to asciify entropy with 2011-10-21 11:55:28 -07:00