1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 16:30:59 +01:00
phorge-phorge/src/applications/legalpad
epriestley 21de2b1a0c Make Projects a PhabricatorSubscribableInterface, but with restricted defaults
Summary:
Ref T4379. I want project subscriptions to work like this (yell if this seems whacky, since it makes subscriptions mean somethign a little different for projects than they do for other objects):

  - You can only subscribe to a project if you're a project member.
  - When you're added as a member, you're added as a subscriber.
  - When you're removed as a member, you're removed as a subscriber.
  - While you're a member, you can optionally unsubscribe.

From a UI perspective:

  - We don't show the subscriber list, since it's going to be some uninteresting subset of the member list.
  - We don't show CC transactions in history, since they're an uninteresting near-approximation of the membership transactions.
  - You only see the subscription controls if you're a member.

To do this, I've augmented `PhabricatorSubscribableInterface` with two new methods. It would be nice if we were on PHP 5.4+ and could just use traits for this, but we should get data about version usage before we think about this. For now, copy/paste the default implementations into every implementing class.

Then, I implemented the interface in `PhabricatorProject` but with alternate defaults.

Test Plan:
  - Used the normal interaction on existing objects.
  - This has no actual effect on projects, verified no subscription stuff mysteriously appeared.
  - Hit the new error case by fiddling with the UI.

Reviewers: btrahan

Reviewed By: btrahan

CC: chad, aran

Maniphest Tasks: T4379

Differential Revision: https://secure.phabricator.com/D8165
2014-02-10 14:29:17 -08:00
..
application Legalpad - remarkup LX to link to LX 2014-02-10 11:27:08 -08:00
capability Allow configuration of default document policies for Legalpad 2014-01-30 11:47:42 -08:00
config Legalpad V0.2 - add mail integration 2013-07-03 16:37:05 -07:00
constants Legalpad V0.1 2013-07-03 11:15:45 -07:00
controller Allow configuration of default document policies for Legalpad 2014-01-30 11:47:42 -08:00
editor Add support for more granular sending of email in application transactions 2013-09-13 15:08:17 -07:00
mail Maniphest - add support for !assign command 2013-10-14 12:29:41 -07:00
phid Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
query Legalpad - fix a bug for documents with no signatures 2014-01-17 14:05:18 -08:00
remarkup Legalpad - remarkup LX to link to LX 2014-02-10 11:27:08 -08:00
storage Make Projects a PhabricatorSubscribableInterface, but with restricted defaults 2014-02-10 14:29:17 -08:00
view Legalpad V0.1 2013-07-03 11:15:45 -07:00