1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 12:12:43 +01:00
phorge-phorge/src/applications/metamta/herald
epriestley 4fa99374be Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it
Summary:
See <https://discourse.phabricator-community.org/t/herald-webhook-is-not-called-but-herald-transcript-tells-me-the-opposite/1098>.

The "Commit Hook" events don't operate on objects and don't use TransactionEditors. They can't call webhooks in a normal way and currently don't call webhooks at all. Stop offering these actions in the UI.

The  "Outbound Mail" event also fires oddly and likely doesn't make much sense to hook anyway.

Test Plan: Verified that these events no longer offer "Call webhooks", while normal events still do.

Differential Revision: https://secure.phabricator.com/D19061
2018-02-11 06:15:29 -08:00
..
PhabricatorMailEmailHeraldField.php Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
PhabricatorMailEmailHeraldFieldGroup.php Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
PhabricatorMailEmailSubjectHeraldField.php Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
PhabricatorMailMustEncryptHeraldAction.php Fix a bad classname reference in the "Must Encrypt" action 2018-02-02 14:57:25 -08:00
PhabricatorMailOutboundMailHeraldAdapter.php Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it 2018-02-11 06:15:29 -08:00
PhabricatorMailOutboundRoutingHeraldAction.php Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
PhabricatorMailOutboundRoutingSelfEmailHeraldAction.php Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
PhabricatorMailOutboundRoutingSelfNotificationHeraldAction.php Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
PhabricatorMetaMTAApplicationEmailHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
PhabricatorMetaMTAEmailHeraldAction.php Add a Herald action to trigger "Must Encrypt" for mail 2018-02-02 14:35:26 -08:00
PhabricatorMetaMTAEmailOthersHeraldAction.php Modularize "Send an Email" Herald actions 2015-08-03 14:33:23 -07:00
PhabricatorMetaMTAEmailSelfHeraldAction.php Modularize "Send an Email" Herald actions 2015-08-03 14:33:23 -07:00