1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 01:38:48 +02:00
phorge-phorge/src
epriestley 68d05934a7 Don't show un-completeable results in people/project autocomplete
Summary:
Fixes T10285.

  - If a result (like a milestone) has no primary hashtag, try to fill in a secondary hashtag.
  - If we can't find any hashtag, don't return the result.

This produces these behaviors:

  - By default, you can't autocomplete milestones.
  - If you give one a hashtag, you can.

We might want to give milestones "special" hashtags eventually (like `#xyz/33`) but this fixes the confusing/broken behavior in the UI and we can wait for a better use case for letting you autocomplete milestones, I think.

Also, don't try to cycle hashtags when renaming milestones. This was a little inconsistent before.

Test Plan:
  - Autocompleted normal projects.
  - Autocompleted milestones with explicit hashtags.
  - No autocomplete entry for milestones with no special hashtags.
  - Used normal typeahead to get tag-less milestones to make sure I didn't break anything.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10285

Differential Revision: https://secure.phabricator.com/D15261
2016-02-12 11:03:21 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Use large text columns to store IP addresses 2016-02-02 10:13:14 -08:00
applications Don't show un-completeable results in people/project autocomplete 2016-02-12 11:03:21 -08:00
docs Fix a couple typos in "why so many databases?" document 2016-02-11 13:49:58 -08:00
extensions
infrastructure Fix a couple of missing translation strings 2016-02-12 08:10:10 -08:00
view Don't show un-completeable results in people/project autocomplete 2016-02-12 11:03:21 -08:00
__phutil_library_init__.php
__phutil_library_map__.php Allow workboard sorting and filtering to be saved as defaults 2016-02-12 07:47:23 -08:00