1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
phorge-phorge/webroot/rsrc/js/application/diff
epriestley 6945e80fee For the diff banner, detect the current changeset better
Summary:
Ref T12733. Currently, we detect the changeset which is in the middle of the screen as the current changeset.

This doesn't always get us the most intuitive changeset, particularly after a navigation from the scroll objective list: when you jump to changeset "X", you'd tend to expect "X" to be shown in the header, but the //next// changeset may be shown if "X" is too short.

Instead, select the changeset near the top of the screen (spanning an invisible line slightly below the banner).

Test Plan: Scrolled and jumped through a document with long and short changesets, saw a more intuitive changeset selected by the banner.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12733

Differential Revision: https://secure.phabricator.com/D17976
2017-05-20 07:04:48 -07:00
..
behavior-preview-link.js Make "View" links on Differential inline comment previews work again 2017-01-02 13:24:02 -08:00
DiffChangeset.js Clean up some minor UI behaviors in Differential 2017-05-19 12:01:58 -07:00
DiffChangesetList.js For the diff banner, detect the current changeset better 2017-05-20 07:04:48 -07:00
DiffInline.js Add quest objectives to the minimap 2017-05-19 12:01:01 -07:00
ScrollObjective.js Add quest objectives to the minimap 2017-05-19 12:01:01 -07:00
ScrollObjectiveList.js Add quest objectives to the minimap 2017-05-19 12:01:01 -07:00