1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
phorge-phorge/resources
epriestley 6a60b8cb6f Set "importStatus" as nonmutable on save()
Summary: Fixes T6840. Depends on D11822, which is a little iffy.

Test Plan:
Verified all references to `importStatus` are either:

  - SQL patches creating the column;
  - reads;
  - writes immediately before an insert; or
  - explicit updates of the column.

That is, I identified no cases of `setImportStatus(X)->save()` on a Commit which may already exist. This //would// break that.

In general, almost all writes go through `$commit->writeImportStatusFlag()`, which is an explicit update.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6840

Differential Revision: https://secure.phabricator.com/D11823
2015-02-19 10:36:36 -08:00
..
builtin Add an icon+background selector for project images 2013-10-17 09:32:34 -07:00
celerity Set "importStatus" as nonmutable on save() 2015-02-19 10:36:36 -08:00
chatbot Remove PhabricatorBotDifferentialNotificationHandler reference in example_config.json for phabot 2014-06-11 09:36:30 -07:00
font Made Meme Generator 2013-01-19 18:43:43 -08:00
sprite Flatten Phabricator logo to white 2015-01-29 09:27:36 -08:00
sql Legalpad - allow for legalpad documents to be required to be signed for using Phabricator 2015-02-12 15:22:56 -08:00
sshd Update repository hosting documentation for all the issues users have hit 2014-03-26 06:44:18 -07:00