1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-11 15:21:03 +01:00
phorge-phorge/src
epriestley 6cf017d680 Fix an unusual issue with intradiff highlighting of files with uncommon end-of-file modifications
Summary:
Fixes T13539. See that task for discussion and a reproduction case.

This algorithm currently counts "\ No newline at end of file" lines as though they were normal source lines. This can cause offset issues in the rare case that a diff contains two of these lines (for each side of the file) and has changes between them (because the last line of the file was modified between the diffs).

Instead, don't count "\" as a display line.

Test Plan:
  - See T13539 and PHI1740.
  - Before: got fatals on the "wild" diff and the synthetic simplified version.
  - After: clean intradiff rendering in both cases.

Maniphest Tasks: T13539

Differential Revision: https://secure.phabricator.com/D21267
2020-05-19 09:06:19 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront When proxying HTTP repository responses from repository nodes, discard content description headers 2020-04-25 07:51:46 -07:00
applications Fix an unusual issue with intradiff highlighting of files with uncommon end-of-file modifications 2020-05-19 09:06:19 -07:00
docs Add "short name", "id", and "phid" variables for external editor URIs 2020-04-19 09:37:53 -07:00
extensions
infrastructure Give selected inline comments are more obvious selected state 2020-05-14 14:35:55 -07:00
view Add "View Raw Remarkup" to inline comments 2020-05-13 17:14:20 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Remove "DifferentialInlineCommentQuery" 2020-05-07 16:07:55 -07:00