epriestley 6d3baa92f9 Execute Herald again after promoting revisions out of the "Draft" state ... Summary: Fixes T13027. Ref T2543. When revisions promote from "Draft" because builds finish or no builds are configured, the status currently switches from "Draft" to "Needs Review" without re-running Herald. This means that some rules -- notably, "Send me an email" rules -- don't fire as soon as they should. Instead of applying this promotion in a hacky way inline, queue it and apply it normally in a second edit, after the current group finishes. Test Plan: - Created a revision, reviewed Herald transcripts. - Saw three Herald passes: - First pass (revision creation) triggered builds and no email. - Second pass (builds finished) did not trigger builds (no update) and did not trigger email (revision still a draft). - Third pass (after promotion out of 'draft') did not trigger builds (no update) but did trigger email (revision no longer a draft). Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13027, T2543 Differential Revision: https://secure.phabricator.com/D18819		2017-12-05 12:13:56 -08:00
..
PhabricatorApplicationTransactionCommentEditor.php	Don't require mentioned objects to have all required fields when editing comments	2017-03-22 09:59:40 -07:00
PhabricatorApplicationTransactionEditor.php	Execute Herald again after promoting revisions out of the "Draft" state	2017-12-05 12:13:56 -08:00
PhabricatorEditEngineConfigurationEditEngine.php	Update EditEngine for two column	2016-03-28 09:18:55 -07:00
PhabricatorEditEngineConfigurationEditor.php	Only validate form subtype edits if subtype transactions are present	2017-03-03 13:44:32 -08:00