1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
phorge-phorge/src
epriestley 6dfc7e48ae Don't let users write summaries or test plans which will become ambiguous in commit messages
Summary:
Ref T11085. To recreate the issue:

  - From the web UI, click "Edit Revision".
  - Write something like this as your "Summary" (i.e., put another field marker, like "Test Plan:", into the summary):

> This is a test of the
> Test Plan: field to see
> if it works.

  - Save changes.

Later, when the summary is amended into a commit message, the parser will see two "Test Plan:" fields and fail to parse the message.

Instead, prevent users from making this edit.

Test Plan: {F1917640}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11085

Differential Revision: https://secure.phabricator.com/D16846
2016-11-12 08:03:46 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Make the "All Day Event" control use a checkbox instead of a dropdown 2016-10-31 14:18:59 -07:00
applications Don't let users write summaries or test plans which will become ambiguous in commit messages 2016-11-12 08:03:46 -08:00
docs Fix some remarkup formatting in the Arcanist lint document 2016-11-12 07:39:12 -08:00
extensions
infrastructure Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
view Rebuild lightbox styles 2016-11-12 15:37:16 +00:00
__phutil_library_init__.php
__phutil_library_map__.php Remove plain-text file view of Diffusion files. 2016-11-10 00:40:09 +00:00