1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-16 03:42:41 +01:00
phorge-phorge/src/applications/differential/parser
epriestley edfc6a6934 Convert some loadPreferences() to getUserSetting()
Summary:
Ref T4103. This doesn't get everything, but takes care of most of the easy stuff.

The tricky-ish bit here is that I need to move timezones, pronouns and translations to proper settings. I expect to pursue that next.

Test Plan:
- Grepped for `loadPreferences` to identify callsites.
- Changed start-of-week setting, loaded Calendar, saw correct start.
- Visited welcome page, read "Adjust Settings" point.
- Loaded Conpherence -- I changed behavior here slightly (switching threads drops the title glyph) but it wasn't consistent to start with and this seems like a good thing to push to the next version of Conpherence.
- Enabled Filetree, toggled in Differential.
- Disabled Filetree, no longer visible in Differential.
- Changed "Unified Diffs" preference to "Small Screens" vs "Always".
- Toggled filetree in Diffusion.
- Edited a task, saw sensible projects in policy dropdown.
- Viewed user profile, uncollapsed/collapsed side nav, reloaded page, sticky'd.
- Toggled "monospaced textareas", used a comment box, got appropriate fonts.
- Toggled durable column.
- Disabled title glyphs.
- Changed monospaced font to 18px/36px impact.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16004
2016-06-02 06:29:20 -07:00
..
__tests__ Prevent "commit message magic words" parser from exploding on "reverts aaaa.....aaz" 2015-08-26 09:35:23 -07:00
DifferentialChangesetParser.php Convert some loadPreferences() to getUserSetting() 2016-06-02 06:29:20 -07:00
DifferentialCommitMessageParser.php Extend from Phobject 2015-06-15 18:02:27 +10:00
DifferentialCustomFieldDependsOnParser.php Clean up various pieces of dead/obsolete Differential code 2014-03-11 13:02:19 -07:00
DifferentialCustomFieldRevertsParser.php Clean up various pieces of dead/obsolete Differential code 2014-03-11 13:02:19 -07:00
DifferentialHunkParser.php Improve HTML mail rendering of inline patches 2016-05-12 12:13:40 -07:00
DifferentialLineAdjustmentMap.php Implement rough content-aware inline adjustment rules for ghosts 2015-05-07 14:09:41 -07:00