1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-29 00:40:57 +01:00
phorge-phorge/src
epriestley 6ed123e080 Propagate "unexpandable" PHIDs to feed notification recipient expansion
Summary:
See PHI466. Ref T13108. Somewhat recently, new rules were added so that "Resigning" from a revision takes you off the default recipient list, even if you're still a member of a project or package that is still a reviewer or subscriber.

However, these rules don't currently apply to the similar expansion which occurs in notifications. If you resign from a revision you may still get some notifications (just not email) if a package or project you're a member of is a reviewer or subscriber.

(Possibly these should eventually share more code, but just get things working for now.)

Test Plan:
  - Created a revision as A.
  - Added B as a reviewer.
  - Added a package B is an owner for as a reviewer.
  - As B, resigned. (Make sure B is also not an explicit subscriber.)
  - Commented on the revision as A.
    - Before: B is included in the expanded notification recipient list.
    - After: B is no longer included in the expanded notification recipient list.

Maniphest Tasks: T13108

Differential Revision: https://secure.phabricator.com/D19244
2018-03-21 11:55:52 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Don't emit Content-Security-Policy when returning a response during preflight setup checks 2018-03-05 06:54:01 -08:00
applications Propagate "unexpandable" PHIDs to feed notification recipient expansion 2018-03-21 11:55:52 -07:00
docs Fix outdated link for Font Awesome icon set 2018-03-20 15:50:52 -07:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Render object monograms and embedding references more gracefully when building a Remarkup table of contents 2018-03-16 15:43:56 -07:00
view Roughly modularize document rendering in Files 2018-03-19 15:17:04 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Add an async driver for document rendering and a crude "Hexdump" document engine 2018-03-19 15:18:05 -07:00