1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-10 05:48:30 +01:00
phorge-phorge/src/applications/legalpad
epriestley 0d99c84bd7 Modernize email command parsing
Summary:
Ref T7199. This prepares for an exciting new world of more powerful "!action" commands. In particular:

  - We parse multiple commands per mail.
  - We parse command arguments (these are currently not used).
  - We parse commands at the beginning or end of mail.

Additionally:

  - Do a quick modernization pass on all handlers.
  - Break legacy compatibility with really hacky Facebook stuff (see T1992). They've theoretically been on notice for a year and a half, and their setup relies on calling very old reply handler APIs directly.
  - Some of these handlers had some copy/paste fluff.
  - The Releeph handler is unreachable, but fix it //in theory//.

Test Plan:
- Sent mail to a file; used "!unsubscribe".
- Sent mail to a legalpad document; used "!unsubscribe".
- Sent mail to a task; used various "!close", "!claim", "!assign", etc.
- Sent mail to a paste.
- Sent mail to a revision; used various "!reject", "!claim", etc.
- Tried to send mail to a pull request but it's not actually reachable.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7199

Differential Revision: https://secure.phabricator.com/D12230
2015-03-31 16:48:27 -07:00
..
application Remove getIconName from all applications 2015-01-30 12:11:21 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
config Add getGroup to ConfigOptions 2015-02-09 13:10:56 -08:00
constants Legalpad - allow for legalpad documents to be required to be signed for using Phabricator 2015-02-12 15:22:56 -08:00
controller Convert all tokenizers to take token/scalar inputs 2015-03-31 14:10:55 -07:00
edge Modernize Legalpad edge types 2015-01-01 11:15:34 +11:00
editor Legalpad - fix requires signature transaction from always being saved 2015-02-17 11:07:14 -08:00
mail Modernize email command parsing 2015-03-31 16:48:27 -07:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Convert all tokenizers to take token/scalar inputs 2015-03-31 14:10:55 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
storage Legalpad - add "no one" signature type 2015-02-17 11:45:20 -08:00
typeahead Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
view Remove @group annotations 2014-07-10 08:12:48 +10:00