1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
phorge-phorge/src
epriestley 6f388f97d9 Improve Phabricator behavior for fatal errors
Summary:
  - Exceptions on the rendering pathway currently go uncaught and result in a
blank page. Commonly, this is a bad require_celerity_resource() call. Although
we can't safely render a page if the rendering pathway is broken, we can show a
useful message.
  - When PHP exits because of a fatal error, there is an opportunity to run code
in the shutdown handler. This allows us to show messages at least some of the
time, e.g. "call to unknown function derp() in somefile.php at line 99"
  - flip dem tables

Test Plan: Added fatals ("derp();") and rendering exceptions
("require_celerity_resource('does-not-exist')") to a controller and verified
that the error handling behavior is now more useful.
Reviewed By: aran
Reviewers: jungejason, tuomaspelkonen, aran
CC: aran, epriestley
Differential Revision: 680
2011-07-18 07:23:01 -07:00
..
aphront Add a document preview to Phriction 2011-07-16 18:48:27 -07:00
applications Add an ID column to slowvote's list view. 2011-07-17 14:20:55 -07:00
docs Add Phriction to the main nav menu 2011-07-12 09:26:51 -07:00
infrastructure Improve Phabricator behavior for fatal errors 2011-07-18 07:23:01 -07:00
storage Improve DarkConsole "Services" and "XHProf" plugins 2011-07-11 12:51:58 -07:00
view Fix conservative CSRF token cycling limit 2011-07-14 08:09:40 -07:00
__celerity_resource_map__.php Use Workflow, not Request, for Differential populate/show more requests 2011-07-16 19:15:54 -07:00
__phutil_library_init__.php Distinguish between aphront and phabricator. 2011-01-22 17:45:28 -08:00
__phutil_library_map__.php Add a document preview to Phriction 2011-07-16 18:48:27 -07:00