1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-04 12:42:43 +01:00
phorge-phorge/src/applications/differential/editor
epriestley 6f508a2258 Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
Summary:
Depends on D19065. Ref T13054. Instead of just updating `containerPHID` and hoping for the best, queue a proper BuildWorker to process a "your container has changed, update it" message.

We also need to remove a (superfluous) `withContainerPHIDs()` when loading active diffs for a revision.

Test Plan:
  - Without daemons, created a revision and saw builds stick in "preparing" with no container PHID, but also stay in draft mode.
  - With daemons, saw builds actually build and get the right container PHID.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13054

Differential Revision: https://secure.phabricator.com/D19066
2018-02-12 12:18:52 -08:00
..
DifferentialDiffEditor.php Fix spelling 2017-10-09 10:48:04 -07:00
DifferentialRevisionEditEngine.php Allow revisions to be held as drafts, even after builds finish 2017-10-31 09:39:32 -07:00
DifferentialTransactionEditor.php Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write 2018-02-12 12:18:52 -08:00