1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc/js/application/diff
epriestley 6fd55d692f Formally track "initial", "committed", and "active" states for inline comments
Summary:
Ref T13559. Various client decisions depend on the "initial" or "committed" states of inline comments. Previously, these were informally constructed from "mostly similar" available values, or glossed over in some cases.

On the server, save the initial state when creating a comment. Save the committed state when applying a "save" operation. Send all three states to the client.

On the client, load and track all three states explicitly.

Test Plan: Created inlines, etc. See followups.

Maniphest Tasks: T13559

Differential Revision: https://secure.phabricator.com/D21653
2021-03-29 09:00:27 -07:00
..
DiffChangeset.js Fix an issue where inlines could be duplicated in the client list 2021-03-29 09:00:23 -07:00
DiffChangesetList.js Make "Open in Editor" use the simple line number of the current selected block 2020-05-21 15:31:16 -07:00
DiffInline.js Formally track "initial", "committed", and "active" states for inline comments 2021-03-29 09:00:27 -07:00
DiffInlineContentState.js Make client inlines track an "active" state 2021-03-29 09:00:24 -07:00
DiffPathView.js Make "hidden" changesets sticky, and show hidden state in the filetree 2020-04-22 16:12:42 -07:00
DiffTreeView.js Mark "low importance" and "owned" changes in the filetree 2020-04-22 11:22:34 -07:00