1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-04 04:32:43 +01:00
phorge-phorge/src/applications/transactions/xaction
epriestley 0943561dcb Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects
Summary:
Fixes T13389. Currently, we try to "newSubtypeMap()" unconditionally, even if the underlying object does not support subtypes.

  - Only try to build a subtype map if subtype transactions are actually being applied.
  - When subtype transactions are applied to a non-subtypable object, fail more explicitly.

Test Plan: Clicked "Make Editable" in a fresh Calendar transaction form, got an editable form instead of a fatal from "newSubtypeMap()". (Calendar events are not currently subtypable.)

Maniphest Tasks: T13389

Differential Revision: https://secure.phabricator.com/D20741
2019-08-28 06:57:04 -07:00
..
PhabricatorCoreCreateTransaction.php
PhabricatorCoreTransactionType.php
PhabricatorCoreVoidTransaction.php
PhabricatorEditEngineCreateOrderTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEngineDefaultCreateTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEngineDefaultTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEngineDisableTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEngineEditOrderTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEngineIsEditTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEngineLocksTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEngineNameTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEngineOrderTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEnginePreambleTransaction.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
PhabricatorEditEngineSubtypeTransaction.php Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects 2019-08-28 06:57:04 -07:00
PhabricatorEditEngineTransactionType.php Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00