mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-18 19:40:55 +01:00
4811e6e7c1
Summary: Fixes T11836. See some prior discussion in T8376#120613. The policy hint in headers in the UI is not exhaustive, and can not reasonably be exhaustive. For example, on a revision, it may say "All Users", but really mean "All users who can see the space this object is in and the repository it belongs to, plus the revision author and reviewers". These rules are explained if you click (and, often, in the documentation), but "All Users" is still at least somewhat misleading. I don't think there's any perfect solution here that balances the needs of both new and experienced users perfectly, but this change tries to do a bit better about avoiding cases where we say something very open (like "All Users") when the real policy is not very open. Specifically, I've made these changes to the header: - Spaces are now listed in the tag, so it will say `(S3 > All Users)` instead of `(All Users)`. They're already listed in the header, this just makes it more explicit that Spaces are a policy container and part of the view policy. - Extended policy objects are now listed in the tag, so it will say `(S3 > rARC > All Users)` for a revision in the Arcanist repository which is also in Space 3. - Objects can now provide a "Policy Codex", which is an object that represents a rulebook of more sophisticated policy descriptions. This codex can replace the tag with something else. - Imported calendar events now say "Uses Import Policy" instead of, e.g., "All Users". I've made these changes to the policy dialog: - Split it into more visually separate sections. - Added an explicit section for extended policies ("You must also have access to these other objects: ..."). - Broken the object policy rules into a "Special Rules" section (for rules like "you can only see a revision if you can see the repository it is part of") and an "Object Policy" section (for the actual object policy). - Tried to make it a little more readable? - The new policy dialogs are great to curl up with in front of a fire with a nice cup of cocoa. I've made these changes to infrastructure: - Implementing `PhabricatorPolicyInterface` no longer requires you to implement `describeAutomaticCapability()`. - Instead, implement `PhabricatorPolicyCodexInterface` and return a `PhabricatorPolicyCodex` object. - This "codex" is a policy rulebook which can set all the policy icons, labels, colors, rules, etc., to properly explain complex policies. - Broadly, the old method was usually either not useful (most objects have no special rules) or not powerful enough (objects with special rules often need to do more in order to explain them). Test Plan: {F1912860} {F1912861} {F1912862} {F1912863} Reviewers: chad Reviewed By: chad Subscribers: avivey Maniphest Tasks: T11836 Differential Revision: https://secure.phabricator.com/D16830 |
||
|---|---|---|
| .. | ||
| calendar | ||
| workboards | ||
| phui-action-list.css | ||
| phui-action-panel.css | ||
| phui-badge.css | ||
| phui-basic-nav-view.css | ||
| phui-big-info-view.css | ||
| phui-box.css | ||
| phui-button.css | ||
| phui-chart.css | ||
| phui-cms.css | ||
| phui-comment-form.css | ||
| phui-crumbs-view.css | ||
| phui-curtain-view.css | ||
| phui-document-pro.css | ||
| phui-document-summary.css | ||
| phui-document.css | ||
| phui-feed-story.css | ||
| phui-fontkit.css | ||
| phui-form-view.css | ||
| phui-form.css | ||
| phui-head-thing.css | ||
| phui-header-view.css | ||
| phui-hovercard.css | ||
| phui-icon-set-selector.css | ||
| phui-icon.css | ||
| phui-image-mask.css | ||
| phui-info-panel.css | ||
| phui-info-view.css | ||
| phui-invisible-character-view.css | ||
| phui-list.css | ||
| phui-object-box.css | ||
| phui-object-item-list-view.css | ||
| phui-pager.css | ||
| phui-pinboard-view.css | ||
| phui-profile-menu.css | ||
| phui-property-list-view.css | ||
| phui-remarkup-preview.css | ||
| phui-segment-bar-view.css | ||
| phui-spacing.css | ||
| phui-status.css | ||
| phui-tag-view.css | ||
| phui-timeline-view.css | ||
| phui-two-column-view.css | ||