1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc/css
epriestley 70d67a3908 Fix the most significant "phantom notification" badness
Summary:
Ref T13124. Ref T13131. Fixes T8953. See PHI512.

When you receieve a notification about an object and then someone hides that object from you (or deletes it), you get a phantom notification which is very difficult to clear.

For now, test that notifications are visible when you open the menu and clear any that are not.

This could be a little more elegant than it is, but the current behavior is very clearly broken. This unbreaks it, at least.

Test Plan:
  - As Alice, configured task stuff to notify me (instead of sending email).
  - As Bailey, added Alice as a subscriber to a task, then commented on it.
  - As Alice, loaded home and saw a notification count. Didn't click it yet.
  - As Bailey, set the task to private.
  - As Alice, clicked the notification bell menu icon.
    - Before change: no unread notifications, bell menu is semi-stuck in a phantom state which you can't clear.
    - After change: bad notifications automatically cleared.

{F5530005}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13131, T13124, T8953

Differential Revision: https://secure.phabricator.com/D19384
2018-04-19 17:24:19 -07:00
..
aphront Give the "Filetree" UI element an explicit background color 2018-04-11 10:42:41 -07:00
application Fix the most significant "phantom notification" badness 2018-04-19 17:24:19 -07:00
core Fix the wrapping/padding behavior of Remarkup code block headers more thoroughly? 2018-04-10 04:37:14 -07:00
diviner Lots of little fixes for Dark Mode (Experimental) 2017-07-19 14:41:23 -07:00
font Remove "Aleo" as specialized font for headers 2017-03-22 09:57:00 -07:00
layout Restore coverage reporting to Diffusion browse UI 2018-04-17 14:51:47 -07:00
phui Show revision sizes using a perplexing, inexplicable symbol code 2018-04-03 12:49:27 -07:00
syntax Generate syntax highlighting CSS from a reusable map 2016-05-05 02:50:48 -07:00
sprite-login.css Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
sprite-tokens.css More tokens 2016-07-03 18:32:40 -07:00