mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 11:52:40 +01:00
181e030535
Summary: Ref T10457. This gives unit test results a more first-class treatment in the Differential UI, and consolidates some rendering code. Test Plan: Before: {F1135536} After: {F1135537} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10457 Differential Revision: https://secure.phabricator.com/D15365
77 lines
2 KiB
PHP
77 lines
2 KiB
PHP
<?php
|
|
|
|
final class DifferentialUnitField
|
|
extends DifferentialCustomField {
|
|
|
|
public function getFieldKey() {
|
|
return 'differential:unit';
|
|
}
|
|
|
|
public function getFieldName() {
|
|
return pht('Unit');
|
|
}
|
|
|
|
public function getFieldDescription() {
|
|
return pht('Shows unit test results.');
|
|
}
|
|
|
|
public function shouldAppearInPropertyView() {
|
|
return true;
|
|
}
|
|
|
|
public function renderPropertyViewValue(array $handles) {
|
|
return null;
|
|
}
|
|
|
|
public function shouldAppearInDiffPropertyView() {
|
|
return true;
|
|
}
|
|
|
|
public function renderDiffPropertyViewLabel(DifferentialDiff $diff) {
|
|
return $this->getFieldName();
|
|
}
|
|
|
|
public function getWarningsForDetailView() {
|
|
$status = $this->getObject()->getActiveDiff()->getUnitStatus();
|
|
|
|
$warnings = array();
|
|
if ($status < DifferentialUnitStatus::UNIT_WARN) {
|
|
// Don't show any warnings.
|
|
} else if ($status == DifferentialUnitStatus::UNIT_AUTO_SKIP) {
|
|
// Don't show any warnings.
|
|
} else if ($status == DifferentialUnitStatus::UNIT_SKIP) {
|
|
$warnings[] = pht(
|
|
'Unit tests were skipped when generating these changes.');
|
|
} else {
|
|
$warnings[] = pht('These changes have unit test problems.');
|
|
}
|
|
|
|
return $warnings;
|
|
}
|
|
|
|
public function renderDiffPropertyViewValue(DifferentialDiff $diff) {
|
|
|
|
$colors = array(
|
|
DifferentialUnitStatus::UNIT_NONE => 'grey',
|
|
DifferentialUnitStatus::UNIT_OKAY => 'green',
|
|
DifferentialUnitStatus::UNIT_WARN => 'yellow',
|
|
DifferentialUnitStatus::UNIT_FAIL => 'red',
|
|
DifferentialUnitStatus::UNIT_SKIP => 'blue',
|
|
DifferentialUnitStatus::UNIT_AUTO_SKIP => 'blue',
|
|
);
|
|
$icon_color = idx($colors, $diff->getUnitStatus(), 'grey');
|
|
|
|
$message = DifferentialRevisionUpdateHistoryView::getDiffUnitMessage($diff);
|
|
|
|
$status = id(new PHUIStatusListView())
|
|
->addItem(
|
|
id(new PHUIStatusItemView())
|
|
->setIcon(PHUIStatusItemView::ICON_STAR, $icon_color)
|
|
->setTarget($message));
|
|
|
|
return $status;
|
|
}
|
|
|
|
|
|
|
|
}
|