1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 13:30:55 +01:00
phorge-phorge/webroot/rsrc/image
epriestley 661c758ff9 Render indent depth changes more clearly
Summary:
Ref T13161. See PHI723. Our whitespace handling is based on whitespace flags like `diff -bw`, mostly just for historical reasons: long ago, the easiest way to minimize the visual impact of indentation changes was to literally use `diff -bw`.

However, this approach is very coarse and has a lot of problems, like detecting `"ab" -> "a b"` as "only a whitespace change" even though this is always semantic. It also causes problems in YAML, Python, etc. Over time, we've added a lot of stuff to mitigate the downsides to this approach.

We also no longer get any benefits from this approach being simple: we need faithful diffs as the authoritative source, and have to completely rebuild the diff to `diff -bw` it. In the UI, we have a "whitespace mode" flag. We have the "whitespace matters" configuration.

I think ReviewBoard generally has a better approach to indent depth changes than we do (see T13161) where it detects them and renders them in a minimal way with low visual impact. This is ultimately what we want: reduce visual clutter for depth-only changes, but preserve whitespace changes in strings, etc.

Move toward detecting and rendering indent depth changes. Followup work:

  - These should get colorblind colors and the design can probably use a little more tweaking.
  - The OneUp mode is okay, but could be improved.
  - Whitespace mode can now be removed completely.
  - I'm trying to handle tabs correctly, but since we currently mangle them into spaces today, it's hard to be sure I actually got it right.

Test Plan: {F6214084}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13161

Differential Revision: https://secure.phabricator.com/D20181
2019-02-19 12:40:05 -08:00
..
actions Conpherence CSS tweaks. 2013-01-25 15:48:04 -08:00
controls Add checkbox images for remarkup 2017-06-06 14:04:09 +00:00
examples PHUIImageMask 2014-06-18 14:09:37 -07:00
icon Rebuild lightbox styles 2016-11-12 15:37:16 +00:00
logo Remove slight wash on transparent background on logo 2016-08-08 13:30:07 -07:00
people Actual 2x avatar, new profile picture options 2015-12-04 13:24:25 -08:00
texture Fancy new headers 2013-07-17 15:53:26 -07:00
avatar.png Add some higher resolution default user images 2017-02-26 09:56:21 -08:00
BFCFDA.png Use pixel as background of timeline 2014-02-13 15:15:58 -08:00
checker_dark.png Change background for image views in Differential 2012-08-13 17:21:16 -07:00
checker_light.png Change background for image views in Differential 2012-08-13 17:21:16 -07:00
checker_lighter.png Switch Pholio over to lighter layout. 2014-06-15 07:44:12 -07:00
chevron-in.png Render indent depth changes more clearly 2019-02-19 12:40:05 -08:00
chevron-out.png Render indent depth changes more clearly 2019-02-19 12:40:05 -08:00
d5d8e1.png Polish up timeline for PHIUTwoColumnView 2016-03-08 17:51:53 -08:00
darkload.gif DarkConsole: fix rendering, move request log, load over ajax 2013-01-28 18:45:32 -08:00
divot.png Allow pages to use new "flexible" nav 2012-08-01 12:31:33 -07:00
grippy_texture.png Allow tasks to be subprioritized by drag-and-drop 2012-04-02 12:12:04 -07:00
lightblue-header.png Use more common styles for setup issue CSS 2014-01-18 08:31:47 -08:00
main_texture.png Minor, updates from @chad: 2012-08-20 16:03:56 -07:00
menu_texture.png Dark sidebar everywhere 2013-01-14 13:40:51 -08:00
phrequent_active.png Remove spurious "+x" from files that shouldn't have it 2013-10-05 05:18:17 -07:00
phrequent_inactive.png Fix 403s in Phrequent by rendering actions as forms, and make properties fancier 2013-03-30 19:37:13 -07:00
resize.png Allow dialogs to opt in to being resizable 2016-06-20 19:13:58 -07:00
sprite-login-X2.png Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
sprite-login.png Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
sprite-tokens-X2.png More tokens 2016-07-03 18:32:40 -07:00
sprite-tokens.png More tokens 2016-07-03 18:32:40 -07:00