1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/releeph
epriestley d2e5afb095 Use application PHIDs in Releeph, plus more
Summary:
Ref T2715. Ref T3551. Ref T603. This does a few things, but they're all sort of small:

  - We commonly use a `getX()` / `attachX()` pattern, but have very similar code in the `getX()` method every time. Provide a convenience method to make this pattern easier to write.
  - We use `willFilterPage()` in many queries, but it currently is called with zero or more results. This means we have a lot of "if no results, return nothing" boilerplate. Make it call only for one or more results.
  - Implement `PhabricatorPolicyInterface` on `ReleephBranch`. A branch has the same policy as its project.
  - Implement `ReleephBranchQuery`.
  - Move the branch PHID type to application PHID infrastructure.

Test Plan: Browsed Releeph. Used `phid.query` to query branch PHIDs.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603, T2715, T3551

Differential Revision: https://secure.phabricator.com/D6512
2013-07-22 12:17:32 -07:00
..
application Use ApplicationSearch in Releeph project list 2013-07-21 08:44:53 -07:00
commitfinder Diffusion - move some DiffusionRequest queries to occur over Conduit 2013-05-14 15:32:19 -07:00
conduit Diffusion - move some DiffusionRequest queries to occur over Conduit 2013-05-14 15:32:19 -07:00
config Releeph (Phabricator part) 2013-03-15 11:28:43 +00:00
constants ReleephRequestStatus 2013-05-11 15:20:16 +01:00
controller Use ApplicationSearch in Releeph project list 2013-07-21 08:44:53 -07:00
differential Diffusion - move some DiffusionRequest queries to occur over Conduit 2013-05-14 15:32:19 -07:00
editor Releeph: use relative URIs 2013-05-22 15:42:30 +01:00
field Always provide a viewer when executing DifferentialRevisionQuery 2013-07-01 12:38:27 -07:00
mail Remove the last hardcoding from PhabricatorMetaMTAReceivedMail 2013-05-17 10:00:49 -07:00
phid Use application PHIDs in Releeph, plus more 2013-07-22 12:17:32 -07:00
query Use application PHIDs in Releeph, plus more 2013-07-22 12:17:32 -07:00
storage Use application PHIDs in Releeph, plus more 2013-07-22 12:17:32 -07:00
view Use ApplicationSearch in Releeph project list 2013-07-21 08:44:53 -07:00
ReleephPHIDConstants.php Use application handle infrastructure for Releeph Requests and Releeph Projects 2013-07-22 12:17:30 -07:00