1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 16:30:59 +01:00
phorge-phorge/src/applications
epriestley 71d0465331 Fix two Pholio subscriptions issues
Summary:
  - Grouping inline comments made us render `array(null)` for the content of a single comment. Detect that this corresponds to empty text.
  - Don't try to mention-subscribe automatic subscribers, like the author.

Test Plan: Tried to mention-subscribe the author, saw no "x subscribed y" transaction generate. Added a real subscriber, saw no empty content render.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5315
2013-03-10 10:59:03 -07:00
..
arcanist/conduit Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
audit Revert audit queries back to original behavior 2013-03-04 14:03:14 -08:00
auth make applicationTransactionsCommentView have a "Login to comment." button if user is not logged in 2013-03-07 13:02:36 -08:00
base Optional body class for dust background. 2013-03-04 10:35:50 -08:00
cache Use direct inclusion, not submodules, to bring Javelin into Phabricator 2013-01-22 12:43:55 -08:00
calendar Have AphrontView implement PhutilSafeHTMLProducerInterface 2013-03-09 13:52:21 -08:00
chatlog Introduce PhabricatorEmptyQueryException 2013-03-06 19:22:00 -08:00
conduit Merge branch 'master' into phutil_tag 2013-02-13 12:42:57 -08:00
config Implement card style and extras for object item lists 2013-03-09 17:55:01 -08:00
conpherence Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
countdown Pre-prepare for hovercards 2013-02-26 14:57:41 -08:00
daemon reduce noise on daemon console 2013-03-08 13:08:11 -08:00
differential Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
diffusion Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
directory/controller Revert audit queries back to original behavior 2013-03-04 14:03:14 -08:00
diviner Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
draft/storage Add draft support to ApplicationTransactions 2012-12-21 05:57:14 -08:00
drydock Convert AphrontTableView to safe HTML 2013-02-09 15:11:38 -08:00
fact Convert AphrontTableView to safe HTML 2013-02-09 15:11:38 -08:00
feed Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
files Introduce PhabricatorEmptyQueryException 2013-03-06 19:22:00 -08:00
flag pht() for Flags 2013-03-07 08:22:11 -08:00
harbormaster Add HarbormasterRunnerWorker, for running CI tests 2012-12-17 13:43:26 -08:00
help/controller Allow speical keys to be bound to keystrokes 2013-03-08 21:19:24 -08:00
herald Require a viewer to load handles 2013-02-28 17:15:09 -08:00
macro Widen pinboard to 280x210. 2013-03-05 08:05:51 -08:00
mailinglists Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
maniphest Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
meta Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
metamta Require a viewer to load handles 2013-02-28 17:15:09 -08:00
notification Introduce PhabricatorEmptyQueryException 2013-03-06 19:22:00 -08:00
oauthserver Fix an OAuthServer issue where an attacker could make a link function over HTTP when it should be HTTPS-only 2013-02-19 16:09:36 -08:00
owners Revert audit queries back to original behavior 2013-03-04 14:03:14 -08:00
paste Introduce PhabricatorEmptyQueryException 2013-03-06 19:22:00 -08:00
people Enabling Admins to set profile pictures for System Agents 2013-03-08 08:31:25 -08:00
phame Introduce PhabricatorEmptyQueryException 2013-03-06 19:22:00 -08:00
phid Support "M" in phid.lookup and ircbot 2013-03-05 12:31:52 -08:00
pholio Group inline transactions in Pholio 2013-03-09 19:23:50 -08:00
phortune Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
phpast Prefill "<?php" in XHPAST view form 2013-03-04 11:29:40 -08:00
phriction Pimping PhrictionListController 2013-03-09 19:48:57 -08:00
policy Introduce PhabricatorEmptyQueryException 2013-03-06 19:22:00 -08:00
ponder Introduce PhabricatorEmptyQueryException 2013-03-06 19:22:00 -08:00
project Implement card style and extras for object item lists 2013-03-09 17:55:01 -08:00
remarkup/conduit Convert Remarkup to safe HTML 2013-02-13 12:34:49 -08:00
repository Implemented option to allow users to view username of repository URIs. 2013-03-07 08:06:09 -08:00
search Support "M" in phid.lookup and ircbot 2013-03-05 12:31:52 -08:00
settings pht() for Settings 2013-03-03 06:52:42 -08:00
slowvote Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
subscriptions Integrate subscriptions with ApplicationTransactions 2013-02-17 06:37:09 -08:00
system Add a user-accessible hook for dumping debug code into an install 2013-03-04 13:45:51 -08:00
tokens Introduce PhabricatorEmptyQueryException 2013-03-06 19:22:00 -08:00
transactions Fix two Pholio subscriptions issues 2013-03-10 10:59:03 -07:00
typeahead Use a policy-aware query for Project typeahead 2013-03-05 14:12:11 -08:00
uiexample Implement card style and extras for object item lists 2013-03-09 17:55:01 -08:00
xhprof Require a viewer to load handles 2013-02-28 17:15:09 -08:00