1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley 6edd29de43 Prevent Firebug from crashing in Firefox 13 / Window 7
Summary:
Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this:

  >>> var f = function(n) { n && f(n - 1); }
  >>> f(10000); // Takes a few ms to run.
  >>> f(40000); // Takes a few ms to run.
  >>> f(50000); // Hangs Firefox.

If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding.

Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing.

Test Plan: Clicked 2000-diff revision in Firefox.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D2870
2012-06-26 18:22:53 -07:00
..
aphlict Improve debug support for notifications 2012-06-20 13:20:47 -07:00
core Prevent Firebug from crashing in Firefox 13 / Window 7 2012-06-26 18:22:53 -07:00
countdown Remove usage of JX.defer in favor of setTimeout 2011-08-10 18:09:59 -07:00
differential Fix dropdown for file whose diff is not displayable 2012-06-19 18:28:28 -07:00
diffusion Render pretty graphical traces for commit branches, etc 2012-03-23 17:11:15 -07:00
herald Allow users to add flags via Herald rules 2012-03-30 13:51:54 -07:00
maniphest Make Maniphest Transaction preview tokenizer aware 2012-04-14 07:05:58 -07:00
owners Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
phame Phame V1 - Phabricator blogging software 2012-04-12 13:09:04 -07:00
phortune For discussion -- Stripe integration 2012-04-04 16:09:29 -07:00
phriction Add a document preview to Phriction 2011-07-16 18:48:27 -07:00
projects Remove "Former" project members 2011-12-16 17:46:02 -08:00
repository Use textContent instead of innerHTML for linking symbols 2012-06-13 14:45:45 -07:00
uiexample Add multiple notifications and notification types 2012-06-17 11:35:36 -07:00