1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/maniphest
epriestley 7969f66dfe Fully modularize the "Quick Actions" menu
Summary:
Ref T10077. Currently, we issue 6+ queries on every page to build this menu, since the menu is built application-by-application.

Build the menu with dedicated modules instead so a single "EditEngine" module can provide all of them with one query.

I'd like to reduce this to 0 queries but I'm not totally sure what we want to do with this menu.

This change removes these items, because EditEngine can not currently provide them:

  - Calendar: Eventually via EditEngine eventually.
  - Conpherence: Probably via EditEngine, doesn't seem too important.
  - People: Maybe via EditEngine, doesn't seem too important? "Welcome" is likely better?
  - Pholio: Eventually via EditEngine.

It adds a bunch of other items as a side effect:

{F1677151}

This reduces the queries issued on every page by ~5.

This also makes quick create actions visible while logged out (see T7073).

Test Plan:
  - Viewed menu while logged in.
  - Viewed menu while logged out.
  - Viewed standalone version of menu.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10077

Differential Revision: https://secure.phabricator.com/D16045
2016-06-05 10:32:01 -07:00
..
__tests__ Modularize content sources 2016-03-26 11:59:45 -07:00
application Fully modularize the "Quick Actions" menu 2016-06-05 10:32:01 -07:00
bulk Fix "Add Project" in bulk editor 2015-07-02 14:24:15 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Mention !status explicitly in the documentation for !close 2016-01-05 15:08:52 -08:00
conduit Modularize content sources 2016-03-26 11:59:45 -07:00
config Update Maniphest for PHUITwoColumnView 2016-03-04 17:26:38 -08:00
constants Update Maniphest for PHUITwoColumnView 2016-03-04 17:26:38 -08:00
controller Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
edge Modernize Pholio edges 2015-01-02 10:11:41 +11:00
editor Fix errant rules for associating projects when dragging tasks within a milestone column 2016-05-03 07:59:05 -07:00
engineextension Move PhabricatorHovercard to PHUIHovercard 2016-02-03 16:26:30 +00:00
export Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
field Add "and" support to "ref" 2015-05-05 07:14:15 +10:00
herald Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign 2015-12-05 12:39:45 -08:00
httpparametertype Make "Create Subtask" work properly in EditEngine 2015-12-08 14:29:58 -08:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
mail Add Maniphest Task email creator to CCs 2015-09-09 14:07:07 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
policyrule Allow PolicyRules to serve as "Object Policies" 2015-06-13 15:44:38 -07:00
query Modernize DifferentialRevisionSearchEngine 2016-05-16 10:44:11 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
search Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
storage Merge TYPE_PROJECT_COLUMNS and TYPE_COLUMN transactions into a more general TYPE_COLUMNS transaction 2016-04-06 09:13:31 -07:00
typeahead Allow Maniphest statuses and priorities to be disabled 2015-12-05 11:01:41 -08:00
view Drop "-pro" suffix and "editpro" URIs for EditEngine in Maniphest 2015-12-08 17:56:59 -08:00