1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-02 09:58:24 +01:00
phorge-phorge/src/applications/dashboard
epriestley 72f82abe07 Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation
Summary:
Fixes T13443. When a panel raises an exception during edit action generation, it currently escapes to top level. Instead, catch it more narrowly.

Additionally, mark "ChangesetSearchEngine" as not being a suitable search engine for use in query panels. There's no list view or search URI so it can't generate a sensible panel.

Test Plan:
  - Added a changeset panel to a dashboard.
  - Before: entire dashboard fataled.
  - After: panel fataled narrowly, menu fatals narrowly, dashboard no longer permits creation of another Changeset query panel.

Maniphest Tasks: T13443

Differential Revision: https://secure.phabricator.com/D20902
2019-11-08 17:15:21 -08:00
..
application Support more than 9 portals 2019-10-02 22:35:59 +03:00
conduit Add skeleton for Portals, a collection of dashboards and other resources 2019-04-02 14:42:26 -07:00
constants Add skeleton for Portals, a collection of dashboards and other resources 2019-04-02 14:42:26 -07:00
controller Add "Move Left" and "Move Right" to dashboard tab panels 2019-05-01 15:35:53 -07:00
editfield Rebuild query panels on top of EditEngine 2019-04-09 14:08:41 -07:00
editor Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel 2019-04-30 08:27:20 -07:00
engine Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation 2019-11-08 17:15:21 -08:00
engineextension On panel pages, show where panels are used 2019-04-12 06:14:21 -07:00
icon Add some new Dashboard icons 2017-03-21 11:00:16 -07:00
install Make the "Install Dashboard" flow smoother 2019-04-09 13:34:09 -07:00
interface On panel pages, show where panels are used 2019-04-12 06:14:21 -07:00
layoutconfig Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages 2019-04-17 12:18:52 -07:00
menuitem Update all existing ProfileMenuItems for the more-structured API 2019-04-02 15:20:39 -07:00
paneltype Consolidate burndown logic into a "BurndownChartEngine" 2019-05-22 05:10:42 -07:00
phid On panel pages, show where panels are used 2019-04-12 06:14:21 -07:00
query Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes 2019-04-14 10:28:19 -07:00
remarkup Allow users who can edit a dashboard to remove invalid / restricted panels 2017-02-04 16:33:47 -08:00
storage Add a "Customize Query" action to query panels to make it easier to make minor query adjustments 2019-05-01 11:01:09 -07:00
typeahead Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes 2019-04-14 10:28:19 -07:00
xaction Add a rough "Chart" Dashboard Panel 2019-05-22 04:36:09 -07:00