mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 19:32:40 +01:00
156b156e77
Summary: Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan: - Ran `arc unit --everything`. - Called `conduit.query`. - Browsed Conduit UI. Reviewers: btrahan Reviewed By: btrahan Subscribers: hach-que, epriestley Maniphest Tasks: T5873, T7803 Differential Revision: https://secure.phabricator.com/D12380
53 lines
1.1 KiB
PHP
53 lines
1.1 KiB
PHP
<?php
|
|
|
|
final class DifferentialGetRawDiffConduitAPIMethod
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'differential.getrawdiff';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht('Retrieve a raw diff');
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
return array(
|
|
'diffID' => 'required diffID',
|
|
);
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'nonempty string';
|
|
}
|
|
|
|
protected function defineErrorTypes() {
|
|
return array(
|
|
'ERR_NOT_FOUND' => pht('Diff not found.'),
|
|
);
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$diff_id = $request->getValue('diffID');
|
|
|
|
$viewer = $request->getUser();
|
|
|
|
$diff = id(new DifferentialDiffQuery())
|
|
->withIDs(array($diff_id))
|
|
->setViewer($viewer)
|
|
->needChangesets(true)
|
|
->executeOne();
|
|
|
|
if (!$diff) {
|
|
throw new ConduitException('ERR_NOT_FOUND');
|
|
}
|
|
|
|
$renderer = id(new DifferentialRawDiffRenderer())
|
|
->setChangesets($diff->getChangesets())
|
|
->setViewer($viewer)
|
|
->setFormat('git');
|
|
|
|
return $renderer->buildPatch();
|
|
}
|
|
|
|
}
|