1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 03:12:41 +01:00
phorge-phorge/src
epriestley 74b860519d Remarkup: Correctly render inline embed layout
Summary:
The generated HTML is like `<p>some text <div …>…</div> more text</p>`, and HTML `<p/>` tags may not contain block content like `<div/>` tags. Browsers actually parse this as if it was `<p>some text </p><div …>…</div> more text<p></p>` (sic).

The layout CSS class already has `display: inline` set, but this is not sufficient. Browser's HTML parser doesn't care what CSS rules will be applied, it only deals with the meanings of tags.

Fixes T7201.

Test Plan:
Verify that the following displays the image inline:

`some text {Fnnn,layout=inline} more text`

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Projects: #remarkup

Maniphest Tasks: T7201

Differential Revision: https://secure.phabricator.com/D11706
2015-02-09 07:52:46 -08:00
..
__tests__ Use PhutilLibraryTestCase 2015-01-07 07:38:08 +11:00
aphront PHUIErrorView 2015-02-01 20:14:56 -08:00
applications Remarkup: Correctly render inline embed layout 2015-02-09 07:52:46 -08:00
docs Stop recommending GitHub as "okay" for bug reports 2015-02-04 15:15:05 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Reduce severity of auth provider warning 2015-02-07 14:45:27 -08:00
view Add bigtext option to PHUIActionPanelView 2015-02-09 07:27:54 -08:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php PHUIActionPanelView 2015-02-07 17:06:28 -08:00