1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/harbormaster/step/HarbormasterArcLintBuildStepImplementation.php
epriestley 8860f4724f Lump Harbormaster build steps into groups
Summary:
Ref T8089. We have a lot of broken/confusing/prototype build steps that I want to hide from users when we unprototype Harbormaster.

The dialog is also just kind of unwieldy.

Organize this UI a little better and put all the sketchy junk in a "prototypes" group that you can't see unless prototypes are enabled.

This doesn't break anything (the old steps will still work fine), but should reduce user confusion.

Test Plan:
Old UI:

{F691439}

New UI (prototypes off):

{F691440}

New UI (prototypes on):

{F691441}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8089

Differential Revision: https://secure.phabricator.com/D13803
2015-08-06 04:19:42 -07:00

42 lines
905 B
PHP

<?php
final class HarbormasterArcLintBuildStepImplementation
extends HarbormasterBuildStepImplementation {
const STEPKEY = 'arcanist.lint';
public function getBuildStepAutotargetPlanKey() {
return HarbormasterBuildArcanistAutoplan::PLANKEY;
}
public function getBuildStepAutotargetStepKey() {
return self::STEPKEY;
}
public function shouldRequireAutotargeting() {
return true;
}
public function getName() {
return pht('Arcanist Lint Results');
}
public function getGenericDescription() {
return pht('Automatic `arc lint` step.');
}
public function getBuildStepGroupKey() {
return HarbormasterBuiltinBuildStepGroup::GROUPKEY;
}
public function execute(
HarbormasterBuild $build,
HarbormasterBuildTarget $build_target) {
return;
}
public function shouldWaitForMessage(HarbormasterBuildTarget $target) {
return true;
}
}