epriestley 9f44ee3933 Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic ... Summary: Ref T13302. In at least some browsers (including Safari and Chrome), when you write this: ``` <a href="#">...</a> ``` ...and then access `<that node>.href`, you get `http://local-domain-whatever.com/path/to/current/page#` back. This is wonderful, but not what we want. Access the raw attribute value instead, which is `#` in all browsers. Test Plan: - In Safari, Chrome, and Firefox: - Clicked "Edit Subtasks" from a task. - Clicked "Select" buttons to select several tasks. - Before: Clicking these button incorrectly closed the dialog (because of D20573). - After: Clicking these buttons now selects tasks without closing the dialog. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13302 Differential Revision: https://secure.phabricator.com/D20590		2019-06-19 10:44:42 -07:00
..
map.php	Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic	2019-06-19 10:44:42 -07:00
packages.php	Remove the ability to drag tasks up and down on (non-Workboard) priority list views	2019-03-12 12:47:36 -07:00