1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 20:22:46 +01:00
phorge-phorge/src/applications/fact
epriestley 769e745a3f In charts, make "min" and "max" into pure functions and formally mark pure functions as pure
Summary:
Depends on D20814. Currently, "min()" and "max()" are still "min(f, n)". This is no longer consistent with the construction of functions a function-generators that are composed at top level.

Turn them into "min(n)" and "max(n)" (i.e., not higher-order functions).

Then, mark all the functions which are pure mathematical functions and not higher-order as "pure". These functions have no function parameters and do not reference external data. For now, this distinction has no immediate implications, but it will simplify the next change (which tracks where data came from when it originated from an external source -- these pure functions never have any source information, since they only apply pure mathematical transformations to data).

Test Plan: Loaded a burnup chart, nothing seemed obviously broken.

Subscribers: yelirekim

Differential Revision: https://secure.phabricator.com/D20815
2019-09-17 09:28:23 -07:00
..
application Render charts from storage instead of just one ad-hoc hard-coded chart 2019-05-22 04:31:48 -07:00
chart In charts, make "min" and "max" into pure functions and formally mark pure functions as pure 2019-09-17 09:28:23 -07:00
controller Consolidate burndown logic into a "BurndownChartEngine" 2019-05-22 05:10:42 -07:00
daemon Stack chart functions in a more physical way 2019-05-22 05:40:39 -07:00
engine Store charts earlier and build them out a little later 2019-05-22 05:39:32 -07:00
extract Remove all application callers to "putInSet()" 2018-12-12 16:41:12 -08:00
fact Replace the chart in Maniphest Reports with a chart driven by Facts 2019-05-22 04:44:10 -07:00
management Make Facts more modern, DRY, and dimensional 2018-02-19 12:05:19 -08:00
query Continue cleaning up queries in the wake of changes to "%Q" 2018-11-16 12:49:44 -08:00
storage Store charts earlier and build them out a little later 2019-05-22 05:39:32 -07:00