mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 03:42:41 +01:00
aa310230b6
Summary: Ref T1266. We won't detect a move/copy if fewer than 3 lines are changed. However, you may move a block like: Complicated Line A Trivial Line B Complicated Line C ...where "Trivial Line B" is something like a curly brace. If you move this block somewhere that happened to previously have a similar trivial curly brace line, we won't be able to find 3 contiguous added lines in order to detect the copy/move. Instead, consider both changed and unchanged lines when trying to find contiguous blocks. This allows us to detect across gaps where lines were not actually changed. This new algorithm may be too liberal (for example, we may end up incorrectly identifying moved/copied code before or after changed lines, not just between changed lines), but we can keep an eye on it and tweak it. The algorithm is better factored and better covered, now. Test Plan: - Added a unit test for this case. - Spot-checked a handful of diffs and generally saw behavior that made sense and looked better than before. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T1266 Differential Revision: https://secure.phabricator.com/D12146 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| DifferentialAffectedPath.php | ||
| DifferentialChangeset.php | ||
| DifferentialCustomFieldNumericIndex.php | ||
| DifferentialCustomFieldStorage.php | ||
| DifferentialCustomFieldStringIndex.php | ||
| DifferentialDAO.php | ||
| DifferentialDiff.php | ||
| DifferentialDiffProperty.php | ||
| DifferentialDiffTransaction.php | ||
| DifferentialDraft.php | ||
| DifferentialHunk.php | ||
| DifferentialInlineComment.php | ||
| DifferentialLegacyHunk.php | ||
| DifferentialModernHunk.php | ||
| DifferentialReviewer.php | ||
| DifferentialRevision.php | ||
| DifferentialSchemaSpec.php | ||
| DifferentialTransaction.php | ||
| DifferentialTransactionComment.php | ||