1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
phorge-phorge/webroot/rsrc/js/application/transactions
epriestley b7843da963 Don't expand folded timelines just because users went to any anchor whatsoever
Summary:
Ref T12970. See PHI43. Currently, the "Show Older Comments" link gets auto-clicked if the user visits **any** anchor. This is not correct.

Instead, only auto-click it if the user visits a numeric anchor. This fixes the behavior approximately 98% of the time. See T12970 for a followup on the remaining ambiguous cases.

Test Plan:
  - Viewed a revision with some folded transactions and a "Show Older Comments" link.
  - Clicked a link to a file in the table of contents, with a hash like `#1234abcd`.
    - Before: Timeline expanded and I ended up somewhere bad.
    - After: Timeline no longer expanded.
  - Manually changed hash to `#1234` (purely numeric), saw timeline expand.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12970

Differential Revision: https://secure.phabricator.com/D18458
2017-08-23 14:52:39 -07:00
..
behavior-comment-actions.js Make Differential inline events actually trigger comment preview refreshes 2017-01-19 12:32:49 -08:00
behavior-reorder-configs.js Allow EditEngine create and edit forms to be reordered 2015-12-08 13:00:54 -08:00
behavior-reorder-fields.js Allow form configurations to retitle and reorder forms and add preambles 2015-11-22 15:12:57 -08:00
behavior-show-older-transactions.js Don't expand folded timelines just because users went to any anchor whatsoever 2017-08-23 14:52:39 -07:00
behavior-transaction-comment-form.js Don't put a spacer line on the bottom of previews 2015-05-18 12:18:10 -07:00
behavior-transaction-list.js When a transaction has no quote ref, render "@user wrote:" properly 2017-04-18 09:51:53 -07:00