1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 03:02:43 +01:00
phorge-phorge/src/applications/repository/engine
epriestley d8550c114d Promote instance identity to the upstream and pass it to commit hooks
Summary:
Fixes T7019. In a cluster environment, pushes currently fail because the commit hook can't identify the instance.

For web processes, the hostname identifies the instance -- but we don't have a hostname in the hook.

For CLI processes, the environment identifies the instance -- but we don't have an environment in the hook under SVN.

Promote the instance identifier into the upstream and pack/unpack it explicitly for hooks. This is probably not useful for anyone but us, but the amount of special-purpose code we're introducing is very small.

I poked at trying to do this in a more general way, but:

  - We MUST know this BEFORE we run code, so the normal subclassing stuff is useless.
  - I couldn't come up with any other parameter which might ever be useful to pass in.

Test Plan: Used `git push` to push code through proxied HTTP, got a clean push.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7019

Differential Revision: https://secure.phabricator.com/D11495
2015-01-27 14:51:48 -08:00
..
__tests__ Skip Mercurial tests if hg is not present 2014-12-29 16:15:37 -08:00
PhabricatorRepositoryCommitRef.php Record parent relationships when discovering commits 2014-05-12 11:47:22 -07:00
PhabricatorRepositoryDiscoveryEngine.php Diffusion - add verifyGitOrigin check to git fetch operation 2014-11-14 18:02:27 -08:00
PhabricatorRepositoryEngine.php Diffusion - add verifyGitOrigin check to git fetch operation 2014-11-14 18:02:27 -08:00
PhabricatorRepositoryMirrorEngine.php Add basic support for mirroring Mercurial repositories 2014-01-30 08:37:12 -08:00
PhabricatorRepositoryPullEngine.php Promote instance identity to the upstream and pass it to commit hooks 2015-01-27 14:51:48 -08:00
PhabricatorRepositoryRefEngine.php Allow repo updates to recover after force push + garbage collection 2014-08-12 12:25:24 -07:00