1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 20:10:55 +01:00
phorge-phorge/src/applications/differential/conduit
epriestley 77b3efafbd Use ModularTransactions for accept/reject/resign in "differential.createcomment"
Summary:
Ref T10967. `differential.createcomment` is a frozen API method which has been obsoleted by `differential.revision.edit`.

It is the only remaining way to apply an "accept", "reject", or "resign" action using the old "ACTION" code.

Instead of using the old code, sneakly apply a new type of transaction in these cases instead.

Then, remove all the remaining old code for this stuff on the write pathways.

Test Plan:
  - Used "differential.createcomment" to accept, reject, and resign from a revision.
  - Grepped for all removed ACTION_X constants, found them only in rendering code.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10967

Differential Revision: https://secure.phabricator.com/D17513
2017-03-20 16:43:43 -07:00
..
DifferentialCloseConduitAPIMethod.php Mark "v3" API methods as stable; mark obsoleted methods as "Frozen" 2017-01-09 07:16:27 -08:00
DifferentialConduitAPIMethod.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialCreateCommentConduitAPIMethod.php Use ModularTransactions for accept/reject/resign in "differential.createcomment" 2017-03-20 16:43:43 -07:00
DifferentialCreateDiffConduitAPIMethod.php Modularize content sources 2016-03-26 11:59:45 -07:00
DifferentialCreateInlineConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialCreateRawDiffConduitAPIMethod.php Modularize content sources 2016-03-26 11:59:45 -07:00
DifferentialCreateRevisionConduitAPIMethod.php Mark "v3" API methods as stable; mark obsoleted methods as "Frozen" 2017-01-09 07:16:27 -08:00
DifferentialFindConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialGetAllDiffsConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialGetCommitMessageConduitAPIMethod.php Remove some remnants of the old ways commit mesage fields worked from Differential 2017-01-13 15:29:07 -08:00
DifferentialGetCommitPathsConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialGetDiffConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialGetRawDiffConduitAPIMethod.php Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
DifferentialGetRevisionCommentsConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialGetRevisionConduitAPIMethod.php Remove arcanist projects from differential 2015-05-19 00:36:52 +10:00
DifferentialParseCommitMessageConduitAPIMethod.php Remove "Revision ID" custom field 2016-12-16 10:22:28 -08:00
DifferentialQueryConduitAPIMethod.php Mark "v3" API methods as stable; mark obsoleted methods as "Frozen" 2017-01-09 07:16:27 -08:00
DifferentialQueryDiffsConduitAPIMethod.php Make differential.querydiffs more liberal about arguments 2017-01-10 13:47:38 -08:00
DifferentialRevisionEditConduitAPIMethod.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialRevisionSearchConduitAPIMethod.php Implement basic differential.revision.search 2016-06-09 09:06:58 -07:00
DifferentialSetDiffPropertyConduitAPIMethod.php Remove some obsolete lint and unit support 2015-08-10 14:16:25 -07:00
DifferentialUpdateRevisionConduitAPIMethod.php Mark "v3" API methods as stable; mark obsoleted methods as "Frozen" 2017-01-09 07:16:27 -08:00