1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 02:12:41 +01:00
phorge-phorge/src/applications/phriction
Bob Trahan 77eae81e1a Policy - fix up DifferentialChangesetParser
Summary:
Ref T7094. We should do a policy query on the files IMO because there exists a scenario where the file gets locked down directly. This requires being a bit more disciplined about setting user, which in turn requires deciding whether or not to show edit / reply links as a separate piece of logic, not conditional on user presence.

This is not the best code but I don't think it gets worse with this and is just some other nuance in any larger cleanup we take on someday.

Test Plan: looked at a revision and noted inline comments rendered correctly with reply / edit actions. looked at a diff standalone and noted no reply / edit actions as expected. looked at a "details" link on a transaction and it rendered correctly. looked at a diff in phriction of page edits and it looked good. grepped around and verified the remaining callsite in diffusion already has the setUser call.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7094

Differential Revision: https://secure.phabricator.com/D11579
2015-01-30 11:17:34 -08:00
..
application Add FontIcon bridge to AppIcons 2015-01-24 23:43:01 -08:00
conduit Phriction - add "create" conduit endpoint 2014-11-07 11:46:25 -08:00
config Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
constants Remove @group annotations 2014-07-10 08:12:48 +10:00
controller Policy - fix up DifferentialChangesetParser 2015-01-30 11:17:34 -08:00
editor Phriction - validateTransactions that need parent ancestry to complete successfully 2014-12-12 11:35:43 -08:00
herald T4666, Support Herald in Phriction 2014-11-11 18:29:36 -08:00
mail Phriction - start the move towards transactions and an editor 2014-10-30 08:59:21 -07:00
markup Process Remarkup in text and HTML email bodies appropriately 2014-11-17 18:27:21 -08:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Fix method visibility for PhabricatorApplicationSearchEngine methods 2015-01-07 07:34:52 +11:00
search Rename PHIDType classes 2014-07-24 08:05:46 +10:00
storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00