1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-27 16:00:59 +01:00
phorge-phorge/webroot/rsrc
epriestley 02315c4c48 Fix double-close on dialogs leading to Javascript console error
Summary:
Ref T13302. The "Close/Cancel" button is currently running two copies of the "dismiss dialog" code, since it's techncally a link with a valid HREF attribute.

An alternate formulation of this is perhaps `if (JX.Stratcom.pass()) { return; }` ("let other handlers react to this event; if something kills it, stop processing"), but `pass()` is inherently someone spooky/fragile so try to get away without it.

Test Plan: Opened the Javascript console, clicked "Edit Task" on a workboard, clicked "Close" on the dialog. Before: event was double-handled leading to a JS error in the console. After: dialog closes uneventfully.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13302

Differential Revision: https://secure.phabricator.com/D20640
2019-07-03 12:38:49 -07:00
..
audio/basic Add a few more sounds 2017-04-19 13:47:23 -07:00
css Differentiate Remarkup header sizes more clearly 2019-06-04 16:03:32 -07:00
externals Fix double-close on dialogs leading to Javascript console error 2019-07-03 12:38:49 -07:00
favicons Dynamically composite favicons from customizable sources 2018-03-12 15:28:41 -07:00
image Render indent depth changes more clearly 2019-02-19 12:40:05 -08:00
js Remove obsolete "options" from workboard "updateCard()" call 2019-07-03 10:06:13 -07:00