mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-14 10:52:41 +01:00
15e71e9bf4
Summary: Currently if I go to leave an inline comment and then decide against it and hit <tab>-<enter>, the inline comment edit dialog closes but the overlay doesn't disappear due to a JS error around trying to access the markup property of null. This fixes that by setting the payload to an array with empty markup so that the JS works and the overlay disappears. Test Plan: clicked on the line number column, then pressed ok and confirmed the dialog closed, the overlay disappeared and there were no JS errors. also tested that for clicking the reply link and when editing an existing inline comment. Reviewed By: aran Reviewers: epriestley, aran CC: aran, bh Revert Plan: OK Differential Revision: 154 |
||
---|---|---|
.. | ||
__init__.php | ||
DifferentialInlineCommentEditController.php |