1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-24 21:48:21 +01:00
phorge-phorge/src/infrastructure/customfield
epriestley c439931373 Respect "disabled" custom field status granted by "subtype" configuration in form validation
Summary:
Fixes T13384. Currently, the subtype "disabled" configuration is not respected when selecting fields for `ROLE_EDIT`.

The only meaningful caller for `ROLE_EDIT` is transaction validation, but transaction validation should respect fields being disabled by subtype configuration.

Test Plan:
  - Added a "required" Maniphest custom field "F", then "disabled" it in a subtype "S".
  - Created a task of subtype "S".
    - Before: Form submission fails with error "F is required", even though the field is not actually visible on the form and can not be set.
    - After: Form submits cleanly and creates the task.

Maniphest Tasks: T13384

Differential Revision: https://secure.phabricator.com/D20726
2019-08-21 18:03:20 -07:00
..
config [Redesign] Remove remaining barColor callsites 2015-05-28 15:17:34 -07:00
datasource Fix documentation behaviors for the new proxy functions for custom datasource fields 2018-02-22 13:01:02 -08:00
editor Allow "Change Subtype" to be selected from the comment action stack 2018-11-28 13:40:40 -08:00
engineextension Organize bulk edit actions into nice groups 2018-01-19 13:22:25 -08:00
exception Mark some strings for translation 2015-06-09 23:06:52 +10:00
field Respect "disabled" custom field status granted by "subtype" configuration in form validation 2019-08-21 18:03:20 -07:00
herald Support "Set X to" as an action in Herald for tokenizer/datasource custom fields 2017-11-28 13:41:52 -08:00
interface Further simplify PhabricatorCustomFieldInterface 2013-08-14 12:34:09 -07:00
parser Prevent "commit message magic words" parser from exploding on "reverts aaaa.....aaz" 2015-08-26 09:35:23 -07:00
query Improve Conduit performance for custom fields 2016-07-31 11:15:58 -07:00
standard Support "date" custom fields in "*.edit" endpoints 2019-07-31 13:10:14 -07:00
storage Improve Conduit performance for custom fields 2016-07-31 11:15:58 -07:00